Add some comments to external APIs #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handeyeco
changed the title
|
Size Change: +121 B (+0.02%) Total Size: 736 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (53fbed2) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2272If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2272 |
handeyeco
added
🐍 project: sss
jeremywiebe
approved these changes
Mar 18, 2025
| @@ -5,6 +5,11 @@ import {getUpgradedWidgetOptions} from "../widgets/upgrade"; | |||
|
|
|||
| import type {PerseusRenderer} from "../data-schema"; | |||
|
|
|||
| /** | |||
| * get a copy of a Perseus item with pre-scoring data removed (ie answers) | |||
There was a problem hiding this comment.
I think we agreed to call this rubric data.
Suggested change
| * get a copy of a Perseus item with pre-scoring data removed (ie answers) | |
| * Return a copy of a Perseus item with rubric data removed (ie answers) |
| /** | ||
| * get a copy of a Perseus item with pre-scoring data removed (ie answers) | ||
| * | ||
| * @param originalItem - the full answer data, includes the correct answer |
There was a problem hiding this comment.
Suggested change
| * @param originalItem - the full answer data, includes the correct answer | |
| * @param originalItem - the original, full Perseus item (which includes the rubric - aka answer data) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Jeremy asked me to add some comments